Refactor HTTP handling to add error handling and reduce duplication#197
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors HTTP handling in the Commons importer to centralize client header management, adds proper error handling for non-JSON responses, and updates dependencies to align with OpenRefine standards.
- Centralizes HTTP handling logic to eliminate code duplication and improve maintainability
- Adds error checking and response validation for API calls
- Updates Java version to 11 and WDTK dependency to stable release
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/main/java/org/openrefine/extensions/commons/importer/FileFetcher.java | Refactors HTTP client usage, adds error handling, and extracts URL building logic |
| pom.xml | Updates Java version to 11, OpenRefine version to 3.9.5, and WDTK dependency to stable release |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
tfmorris
force-pushed
the
192-http-cleanup
branch
from
24040ec to
e9b33c8
Compare
Member
|
Thank you so much Tom! I will get to this soon and make sure to make another prerelease. I want to update the release documentation before making a proper release, my hope is to get to that next week giving this a few days in the wild. |
Member
|
Thank you @tfmorris! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #192
Update WDTK dependency to the version that includes the User Agent fix- this was moved to a separate PR to reenable the CI pipeline and was already mergedisBlank())Some non-essential changes which are included, but could be removed (the current code was making my head hurt):